Re: [RFC v2 06/10] exynos5-fimc-is: Adds isp subdev

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/09/2013 01:42 PM, Arun Kumar K wrote:
+       /* Check if same as sensor width&   height */
>>
>>  +       sensor_width = p->sensor->drvdata->pixel_width;
>>  +       sensor_height = p->sensor->drvdata->pixel_height;
>>  +       if ((sensor_width != f->fmt.pix_mp.width) ||
>>  +               (sensor_height != f->fmt.pix_mp.height)) {
>
>
>  What's the point of this check ?
>
Check was added to ensure ISP input width and height is
set same as the sensor output or not.
But yes this cannot be extended to generic (non-IS controlled) sensors.
Will drop this check and let media controller take care.

>
>>  +               f->fmt.pix_mp.width = sensor_width;
>>  +               f->fmt.pix_mp.height = sensor_height;
>>  +       }

I meant that you could do the assignment unconditionally, since you
always end up with sensor_width/height assigned to pix_mp.width/height.
Indeed, this should be handled by subdev ioctls, and any discrepancies
should be detected while starting streaming and reported to user space.

--
Thanks,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux