Hi Sergei
On Fri, 28 Jun 2013, Sergei Shtylyov wrote:
> Hello.
>
> On 06/28/2013 03:58 AM, Vladimir Barinov wrote:
>
> > > > From: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx>
>
> > > > Add Renesas R-Car VIN (Video In) V4L2 driver.
>
> > > > Based on the patch by Phil Edworthy <phil.edworthy@xxxxxxxxxxx>.
>
> > > > Signed-off-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx>
> > > > [Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed
> > > > 'enum chip_id'
> > > > values, reordered rcar_vin_id_table[] entries, removed senseless
> > > > parens from
> > > > to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {}
> > > > to the
> > > > *if* statement and used 'bool' values instead of 0/1 where
> > > > necessary, removed
> > > > unused macros, done some reformatting and clarified some comments.]
> > > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
>
> > > Reviewing this iteration of the patch is still on my todo, in the
> > > meantime you might verify whether it works on top of the for-3.11-3
> > > branch of my
>
> > > http://git.linuxtv.org/gliakhovetski/v4l-dvb.git
>
> > > git-tree, or "next" after it's been pulled by Mauro and pushed
> > > upstream. With that branch you shouldn't need any additional patches
> > > andy more.
>
> > Actually we need to apply/merge more patches here that enables VIN
> > support on separate platform (like pinctrl/clock/setup/) :)
>
> > Despite of above the rcar_vin driver works fine on Marzen board in
> > v4l-dvb.git after adding soc_camera_host_ops clock_start/clock_stop.
>
> Guennadi, does that mean that we should rebase the driver to the branch
> that you've named now?
IIUC, your last couple of versions were already developed on top of
v4l2-clk + v4l2-asybc + soc_scale_crop patches, right? But those patches
were out of tree, and thus unstable. Whereas now they've hit Mauro's tree
at git.linuxtv.org and are about to be pulled into "next." So, you don't
need anymore to apply any external patches, you will be able to just
develop on top of "next." I presume, this should make your work easier,
not harder. Just please make sure to double-check your stack on top of
"next" to make sure it still works. And let's try to get your driver ready
for 3.12.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
