Re: [REVIEW PATCH 2/3] bfin_capture: fix compiler warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2013/6/21 Hans Verkuil <hverkuil@xxxxxxxxx>:
> From: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>
> media-git/drivers/media/platform/blackfin/bfin_capture.c: In function ‘bcap_probe’:
> media-git/drivers/media/platform/blackfin/bfin_capture.c:1007:16: warning: ignoring return value of ‘vb2_queue_init’, declared with attribute warn_unused_result [-Wunused-result]
>   vb2_queue_init(q);
>                   ^
>
> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> Cc: Scott Jiang <scott.jiang.linux@xxxxxxxxx>
> ---
>  drivers/media/platform/blackfin/bfin_capture.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/blackfin/bfin_capture.c b/drivers/media/platform/blackfin/bfin_capture.c
> index 6652e71..7f838c6 100644
> --- a/drivers/media/platform/blackfin/bfin_capture.c
> +++ b/drivers/media/platform/blackfin/bfin_capture.c
> @@ -1004,7 +1004,9 @@ static int bcap_probe(struct platform_device *pdev)
>         q->mem_ops = &vb2_dma_contig_memops;
>         q->timestamp_type = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
>
> -       vb2_queue_init(q);
> +       ret = vb2_queue_init(q);
> +       if (ret)
> +               goto err_free_handler;
>
>         mutex_init(&bcap_dev->mutex);
>         init_completion(&bcap_dev->comp);

Acked-by: Scott Jiang <scott.jiang.linux@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux