RE: [PATCH] mem2mem_testdev: fix missing v4l2_dev assignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hans,

> From: Hans Verkuil [mailto:hverkuil@xxxxxxxxx]
> Sent: Wednesday, June 26, 2013 8:31 AM
> 
> Hi Kamil,
> 
> This patch adds the missing v4l2_dev assignment as reported by
> Fengguang.
> 
> It also fixes a poorly formatted message:
> 
> m2m-testdev m2m-testdev.0: mem2mem-testdevDevice registered as
> /dev/video0
> 
> Is it OK if I take this through my tree? I have similar fix as well in
> another driver.

Go ahead :)

Best wishes,
Kamil

> 
> Regards,
> 
> 	Hans
> 
> diff --git a/drivers/media/platform/mem2mem_testdev.c
> b/drivers/media/platform/mem2mem_testdev.c
> index 4cc7f65d..6a17676 100644
> --- a/drivers/media/platform/mem2mem_testdev.c
> +++ b/drivers/media/platform/mem2mem_testdev.c
> @@ -1051,6 +1051,7 @@ static int m2mtest_probe(struct platform_device
> *pdev)
> 
>  	*vfd = m2mtest_videodev;
>  	vfd->lock = &dev->dev_mutex;
> +	vfd->v4l2_dev = &dev->v4l2_dev;
> 
>  	ret = video_register_device(vfd, VFL_TYPE_GRABBER, 0);
>  	if (ret) {
> @@ -1061,7 +1062,7 @@ static int m2mtest_probe(struct platform_device
> *pdev)
>  	video_set_drvdata(vfd, dev);
>  	snprintf(vfd->name, sizeof(vfd->name), "%s",
> m2mtest_videodev.name);
>  	dev->vfd = vfd;
> -	v4l2_info(&dev->v4l2_dev, MEM2MEM_TEST_MODULE_NAME
> +	v4l2_info(&dev->v4l2_dev,
>  			"Device registered as /dev/video%d\n", vfd->num);
> 
>  	setup_timer(&dev->timer, device_isr, (long)dev);


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux