Hi Sylwester On Mon, 24 Jun 2013, Sylwester Nawrocki wrote: > Hi Guennadi, > > On 06/24/2013 01:20 PM, Guennadi Liakhovetski wrote: > > Add documentation for the V4L2 clock and V4L2 asynchronous probing APIs > > to v4l2-framework.txt. > > > > Signed-off-by: Guennadi Liakhovetski<g.liakhovetski@xxxxxx> > > --- > > > > v2: addressed comments by Hans and Laurent (thanks), including > > (a) language clean up > > (b) extended the V4L2 clock API section with an explanation, what special > > requirements V4L2 has and a mention of it being temporary until CCF is > > used by all > > (c) added an explanation of the use of -EPROBE_DEFER > > Looks pretty good. > > Reviewed-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> Thanks > > Just one remark below... > > > Documentation/video4linux/v4l2-framework.txt | 73 > > +++++++++++++++++++++++++- > > 1 files changed, 71 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/video4linux/v4l2-framework.txt > > b/Documentation/video4linux/v4l2-framework.txt > > index b5e6347..00a9d21 100644 > > --- a/Documentation/video4linux/v4l2-framework.txt > > +++ b/Documentation/video4linux/v4l2-framework.txt > > @@ -325,8 +325,27 @@ that width, height and the media bus pixel code are > > equal on both source and > > sink of the link. Subdev drivers are also free to use this function to > > perform the checks mentioned above in addition to their own checks. > > > > -A device (bridge) driver needs to register the v4l2_subdev with the > > -v4l2_device: > > +There are currently two ways to register subdevices with the V4L2 core. The > > +first (traditional) possibility is to have subdevices registered by bridge > > +drivers. This can be done when the bridge driver has the complete > > information > > +about subdevices connected to it and knows exactly when to register them. > > This > > +is typically the case for internal subdevices, like video data processing > > units > > +within SoCs or complex PCI(e) boards, camera sensors in USB cameras or > > connected > > +to SoCs, which pass information about them to bridge drivers, usually in > > their > > +platform data. > > + > > +There are however also situations where subdevices have to be registered > > +asynchronously to bridge devices. An example of such a configuration is a > > Device > > +Tree based systems where information about subdevices is made available to > > the > > I think you need to substitute "is a Device Tree based systems" with either: > "are Device Tree based systems" or > "is a Device Tree based system". Oops, sure, thanks for spotting, I'll s/systems/system/ when pushing this up. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
