Hello. On 06/13/2013 05:12 PM, Guennadi Liakhovetski wrote:
Hi Sergei
Patches, that this commit is based upon are hopefully moving towards the mainline, but it's still possible, that some more changes will be required. In any case, I wanted to comment to this version to let you prepare for a new version in advance.
In general - looks better!
From: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx>
Add Renesas R-Car VIN (Video In) V4L2 driver.
Based on the patch by Phil Edworthy <phil.edworthy@xxxxxxxxxxx>.
Signed-off-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx> [Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed 'enum chip_id' values, reordered rcar_vin_id_table[] entries, removed senseless parens from to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {} to the *if* statement and used 'bool' values instead of 0/1 where necessary, removed unused macros, done some reformatting and clarified some comments.] Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
---
[snip]
Index: media_tree/drivers/media/platform/soc_camera/rcar_vin.c =================================================================== --- /dev/null +++ media_tree/drivers/media/platform/soc_camera/rcar_vin.c
[...]
+static irqreturn_t rcar_vin_irq(int irq, void *data) +{
[...]
+ if (hw_stopped || !can_run) { + priv->state = STOPPED; + } else if (is_continuous_transfer(priv) && + list_empty(&priv->capture) && + priv->state == RUNNING) { + /* + * The continuous capturing requires an explicit stop + * operation when there is no buffer to be set into + * the VnMBm registers. + */ + rcar_vin_request_capture_stop(priv); + } else { + rcar_vin_capture(priv); + }
You don't need braces here
Did you mean only *else* branch or the whole *if statement? In both cases, I disagree. Removing {} only from *else* contradicts do Documenation/CodingStyle, removing them from the *if* branch too also don't appeal to me as due to the comment inside the *if* branch. Sorry, I'm leaving this as is.
WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
