Hi Andrzej,
Thank you for the patch.
On Thursday 16 May 2013 10:14:33 Andrzej Hajda wrote:
> This patch adds managed version of initialization
> function for v4l2 control handler.
>
> Signed-off-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx>
> Reviewed-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> v3:
> - removed managed cleanup
> v2:
> - added missing struct device forward declaration,
> - corrected few comments
> ---
> drivers/media/v4l2-core/v4l2-ctrls.c | 32 +++++++++++++++++++++++++++++++
> include/media/v4l2-ctrls.h | 16 ++++++++++++++++
> 2 files changed, 48 insertions(+)
>
> diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c
> b/drivers/media/v4l2-core/v4l2-ctrls.c index ebb8e48..f47ccfa 100644
> --- a/drivers/media/v4l2-core/v4l2-ctrls.c
> +++ b/drivers/media/v4l2-core/v4l2-ctrls.c
> @@ -1421,6 +1421,38 @@ void v4l2_ctrl_handler_free(struct v4l2_ctrl_handler
> *hdl) }
> EXPORT_SYMBOL(v4l2_ctrl_handler_free);
>
> +static void devm_v4l2_ctrl_handler_release(struct device *dev, void *res)
> +{
> + struct v4l2_ctrl_handler **hdl = res;
> +
> + v4l2_ctrl_handler_free(*hdl);
> +}
> +
> +int devm_v4l2_ctrl_handler_init(struct device *dev,
> + struct v4l2_ctrl_handler *hdl,
> + unsigned nr_of_controls_hint)
> +{
> + struct v4l2_ctrl_handler **dr;
> + int rc;
> +
> + dr = devres_alloc(devm_v4l2_ctrl_handler_release, sizeof(*dr),
> + GFP_KERNEL);
> + if (!dr)
> + return -ENOMEM;
> +
> + rc = v4l2_ctrl_handler_init(hdl, nr_of_controls_hint);
> + if (rc) {
> + devres_free(dr);
> + return rc;
> + }
> +
> + *dr = hdl;
> + devres_add(dev, dr);
> +
> + return 0;
> +}
> +EXPORT_SYMBOL_GPL(devm_v4l2_ctrl_handler_init);
> +
> /* For backwards compatibility: V4L2_CID_PRIVATE_BASE should no longer
> be used except in G_CTRL, S_CTRL, QUERYCTRL and QUERYMENU when dealing
> with applications that do not use the NEXT_CTRL flag.
> diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
> index 7343a27..169443f 100644
> --- a/include/media/v4l2-ctrls.h
> +++ b/include/media/v4l2-ctrls.h
> @@ -25,6 +25,7 @@
> #include <linux/videodev2.h>
>
> /* forward references */
> +struct device;
> struct file;
> struct v4l2_ctrl_handler;
> struct v4l2_ctrl_helper;
> @@ -306,6 +307,21 @@ int v4l2_ctrl_handler_init_class(struct
> v4l2_ctrl_handler *hdl, */
> void v4l2_ctrl_handler_free(struct v4l2_ctrl_handler *hdl);
>
> +/*
> + * devm_v4l2_ctrl_handler_init - managed control handler initialization
> + *
> + * @dev: Device the @hdl belongs to.
> + * @hdl: The control handler.
> + * @nr_of_controls_hint: A hint of how many controls this handler is
> + * expected to refer to.
> + *
> + * This is a managed version of v4l2_ctrl_handler_init. Handler initialized
> with + * this function will be automatically cleaned up on driver detach. +
> */
> +int devm_v4l2_ctrl_handler_init(struct device *dev,
> + struct v4l2_ctrl_handler *hdl,
> + unsigned nr_of_controls_hint);
> +
> /** v4l2_ctrl_handler_setup() - Call the s_ctrl op for all controls
> belonging * to the handler to initialize the hardware to the current
> control values. * @hdl: The control handler.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
