Hi Kamil, Thank you for the review. >> #define IS_MFCV6(dev) (dev->variant->version >= 0x60 ? 1 : > 0) >> +#define IS_MFCV7(dev) (dev->variant->version >= 0x70 ? 1 : > 0) > > According to this, MFC v7 is also detected as MFC v6. Was this intended? Yes this was intentional as most of v7 will be reusing the v6 code and only minor changes are there w.r.t firmware interface. > I think that it would be much better to use this in code: > if (IS_MFCV6(dev) || IS_MFCV7(dev)) > And change the define to detect only single MFC revision: > #define IS_MFCV6(dev) (dev->variant->version >= 0x60 && > dev->variant->version < 0x70) > I kept it like that since the macro IS_MFCV6() is used quite frequently in the driver. Also if MFCv8 comes which is again similar to v6 (not sure about this), then it will add another OR condition to this check. > Other possibility I see is to change the name of the check. Although > IS_MFCV6_OR_NEWER(dev) seems too long :) > How about making it IS_MFCV6_PLUS()? Regards Arun -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
