Hi Sakari, On 06/11/2013 12:50 PM, Sakari Ailus wrote: > On Mon, Jun 10, 2013 at 04:54:28PM +0200, Sylwester Nawrocki wrote: >> This is an updated version of the patch set >> http://www.spinics.net/lists/linux-media/msg64536.html >> >> Comparing to v2 it includes improvements of the __media_entity_remove_links() >> function, thanks to Sakari. >> >> The cover letter of v2 is included below. >> >> This small patch set adds a function for removing all links at a media >> entity. I found out such a function is needed when media entites that >> belong to a single media device have drivers in different kernel modules. >> This means virtually all camera drivers, since sensors are separate >> modules from the host interface drivers. >> >> More details can be found at each patch's description. >> >> The links removal from a media entity is rather strightforward, but when >> and where links should be created/removed is not immediately clear to me. >> >> I assumed that links should normally be created/removed when an entity >> is registered to its media device, with the graph mutex held. >> >> I'm open to opinions whether it's good or not and possibly suggestions >> on how those issues could be handled differently. >> >> The changes since original version are listed in patch 1/2, in patch 2/2 >> only the commit description has changed slightly. > > Acked-by: Sakari Ailus <sakari.ailus@xxxxxx> > > That said, I'd wish they won't be merged before the two patches I'm sending > shortly. The thing is that the media entity links array is freed by > media_entity_cleanup(), and there are two drivers that call > media_entity_cleanup() first. The patches fix the issue, so could you > prepend them to your set (after review, naturally)? Your patches look good, thanks a lot for inspecting those drivers! I'm going to put all those patches on a separate branch and will hold on with sending a pull request for a couple days. Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
