Re: [PATCH v2] ov10635: Add OmniVision ov10635 SoC camera driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Guennadi,

> Thanks for the patch. I'll look at it in more detail hopefully soon 
> enough... One remark so far to Jean-Philippe's comment:
> 
[snip]
> > Register 0x3042 is only touched by the enable part, not by the "change
> > mode" part
> > I think you could move the {0x3042, 0xf0} sequence in the
> > standard_regs array, and keep
> > only the 0x301b, 0x301c, 0x301a registers.
> > 
> > By the way, did you test with a single write ? There is the same
> > sequence in ov5642
> > init, so I believe it is copy pasted in every omnivision init. Is it
> > actually useful ?
> 
> If this is indeed the case and all OV sensor camera drivers use the same 

> initialisation sequence, maybe it's time to consider making one firmware 

> file for them all and loading it in user-space?

After looking at other OV drivers, the sequences are very different. I 
think Jean-Philippe's comment was specific to data files that OV provide 
for their cameras.

Regards
Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux