Hi Hans,
> Subject: Re: [PATCH] ov10635: Add OmniVision ov10635 SoC camera driver
<snip>
> > +#include <media/v4l2-chip-ident.h>
>
> Don't implement chip_ident or use this header: it's going to be
> removed in 3.11.
<snip>
> > +/* Set status of additional camera capabilities */
> > +static int ov10635_s_ctrl(struct v4l2_ctrl *ctrl)
> > +{
> > + struct ov10635_priv *priv = container_of(ctrl->handler,
> > + struct ov10635_priv, hdl);
> > + struct i2c_client *client = v4l2_get_subdevdata(&priv->subdev);
> > +
> > + switch (ctrl->id) {
> > + case V4L2_CID_VFLIP:
> > + if (ctrl->val)
> > + return ov10635_reg_rmw(client, OV10635_VFLIP,
> > + OV10635_VFLIP_ON, 0);
> > + else
>
> No need for 'else'.
Ok.
> > + return ov10635_reg_rmw(client, OV10635_VFLIP,
> > + 0, OV10635_VFLIP_ON);
> > + break;
>
> No need for 'break'. Ditto for HFLIP.
Ok.
<snip>
> > +/* Get chip identification */
> > +static int ov10635_g_chip_ident(struct v4l2_subdev *sd,
> > + struct v4l2_dbg_chip_ident *id)
> > +{
> > + struct i2c_client *client = v4l2_get_subdevdata(sd);
> > + struct ov10635_priv *priv = to_ov10635(client);
> > +
> > + id->ident = priv->model;
> > + id->revision = priv->revision;
> > +
> > + return 0;
> > +}
>
> Drop this function, no longer needed.
<snip>
> > diff --git a/include/media/v4l2-chip-ident.h b/include/media/v4l2-
> chip-ident.h
> > index 4ee125b..8fc3303 100644
> > --- a/include/media/v4l2-chip-ident.h
> > +++ b/include/media/v4l2-chip-ident.h
> > @@ -77,6 +77,7 @@ enum {
> > V4L2_IDENT_OV2640 = 259,
> > V4L2_IDENT_OV9740 = 260,
> > V4L2_IDENT_OV5642 = 261,
> > + V4L2_IDENT_OV10635 = 262,
> >
> > /* module saa7146: reserved range 300-309 */
> > V4L2_IDENT_SAA7146 = 300,
> >
>
> This can be dropped as well, because this header will go away.
Thanks for the very quick review! I'll have a look at the media tree to
see what's changing wrt the chip ident.
Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
