Ping?
regards,
dan carpenter
On Sat, Apr 13, 2013 at 12:32:15PM +0300, Dan Carpenter wrote:
> These structs have holes and reserved struct members which aren't
> cleared. I've added a memset() so we don't leak stack information.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
> index 99b80b6..450c0d1 100644
> --- a/drivers/media/media-device.c
> +++ b/drivers/media/media-device.c
> @@ -139,6 +139,8 @@ static long __media_device_enum_links(struct media_device *mdev,
>
> for (p = 0; p < entity->num_pads; p++) {
> struct media_pad_desc pad;
> +
> + memset(&pad, 0, sizeof(pad));
> media_device_kpad_to_upad(&entity->pads[p], &pad);
> if (copy_to_user(&links->pads[p], &pad, sizeof(pad)))
> return -EFAULT;
> @@ -156,6 +158,7 @@ static long __media_device_enum_links(struct media_device *mdev,
> if (entity->links[l].source->entity != entity)
> continue;
>
> + memset(&link, 0, sizeof(link));
> media_device_kpad_to_upad(entity->links[l].source,
> &link.source);
> media_device_kpad_to_upad(entity->links[l].sink,
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
