On Tue, 2013-05-28 at 08:42 +0200, Hans Verkuil wrote: > On Mon May 27 2013 23:53:15 Ben Hutchings wrote: > > On Mon, 2013-05-27 at 21:56 +0200, Hans Verkuil wrote: > > > On Mon May 27 2013 18:24:32 Ben Hutchings wrote: > > > > On Thu, 2013-05-23 at 10:25 +0200, Hans Verkuil wrote: > > > > > Hi Ben, David, > > > > > > > > > > The go7007 staging driver has been substantially overhauled for kernel 3.10. > > > > > As part of that process the firmware situation has been improved as well. > > > > > > > > > > While Micronas allowed the firmware to be redistributed, it was never made > > > > > part of linux-firmware. Only the firmwares for the Sensoray S2250 were added > > > > > in the past, but those need the go7007*.bin firmwares as well to work. > > > > > > > > > > This pull request collects all the firmwares necessary to support all the > > > > > go7007 devices into the go7007 directory. With this change the go7007 driver > > > > > will work out-of-the-box starting with kernel 3.10. > > > > [...] > > > > > > > > You should not rename files like this. linux-firmware is not versioned > > > > and needs to be compatible with old and new kernel versions, so far as > > > > possible. > > > > > > I understand, and I wouldn't have renamed these two firmware files if it > > > wasn't for the fact that 1) it concerns a staging driver, so in my view > > > backwards compatibility is not a requirement, > > > > This driver (or set of drivers) has been requesting go7007fw.bin, > > go7007tv.bin, s2250.fw and s2250_loader.fw for nearly 5 years. It's a > > bit late to say those were just temporary filenames. > > Why not? It is a staging driver for good reasons. Just because it is in staging > for a long time (because nobody found the time to actually work on it until > 3.10) doesn't mean it magically becomes non-staging. The Kconfig in staging > says: > > This option allows you to select a number of drivers that are > not of the "normal" Linux kernel quality level. These drivers > are placed here in order to get a wider audience to make use of > them. Please note that these drivers are under heavy > development, may or may not work, and may contain userspace > interfaces that most likely will be changed in the near > future. > > In other words, there are no guarantees. That's the whole point of staging. [...] But the reality is that many drivers don't get that heavy development, and so they linger in staging for a long time. So it shouldn't be surprising that users start to rely on them, and distributions ship them, and then it's a bit rough to pull the rug from under them some years later. I don't know how true that is of go7007 but I'd like to avoid causing regressions. So I've pulled from you, but I've then added back s2250.fw and s2250_loader.fw as symlinks. Ben. -- Ben Hutchings If at first you don't succeed, you're doing about average.
Attachment:
signature.asc
Description: This is a digitally signed message part
