Am Mittwoch, den 29.05.2013, 14:28 +0200 schrieb Kamil Debski: > Hi, > > Patches 5/9 an 6/9 have a style issues (Line > 80) found by checkpatch. > Can you comment on this? I think that especially with the CODA_CODEC array, readability is improved by overstepping the 80 character barrier. > Also patch 8/9 does not apply cleanly to my branch. I think that it might be > because > I am missing patches that were taken by Hans. That is correct. I should have mentioned those are prerequisites. regards Philipp > Warnings from checkpatch: > > Patch 5/9 > > WARNING: line over 80 characters > #73: FILE: drivers/media/platform/coda.c:959: > + coda_parabuf_write(ctx, i * 3 + 2, paddr + ysize + ysize/4); > /* Cr */ > > WARNING: line over 80 characters > #99: FILE: drivers/media/platform/coda.c:961: > + if (dev->devtype->product != CODA_DX6 && fourcc == > V4L2_PIX_FMT_H264) > > WARNING: line over 80 characters > #100: FILE: drivers/media/platform/coda.c:962: > + coda_parabuf_write(ctx, 96 + i, > ctx->internal_frames[i].paddr + ysize + ysize/4 + ysize/4); > > total: 0 errors, 3 warnings, 76 lines checked > > Patch 6/9 > WARNING: line over 80 characters > #186: FILE: drivers/media/platform/coda.c:293: > + CODA_CODEC(CODADX6_MODE_ENCODE_H264, V4L2_PIX_FMT_YUV420, > V4L2_PIX_FMT_H264, 720, 576), > > WARNING: line over 80 characters > #187: FILE: drivers/media/platform/coda.c:294: > + CODA_CODEC(CODADX6_MODE_ENCODE_MP4, V4L2_PIX_FMT_YUV420, > V4L2_PIX_FMT_MPEG4, 720, 576), > > WARNING: line over 80 characters > #191: FILE: drivers/media/platform/coda.c:298: > + CODA_CODEC(CODA7_MODE_ENCODE_H264, V4L2_PIX_FMT_YUV420, > V4L2_PIX_FMT_H264, 1280, 720), > > WARNING: line over 80 characters > #192: FILE: drivers/media/platform/coda.c:299: > + CODA_CODEC(CODA7_MODE_ENCODE_MP4, V4L2_PIX_FMT_YUV420, > V4L2_PIX_FMT_MPEG4, 1280, 720), > > WARNING: line over 80 characters > #584: FILE: drivers/media/platform/coda.c:1110: > + value |= (q_data_src->height & CODADX6_PICHEIGHT_MASK) << > CODA_PICHEIGHT_OFFSET; > > WARNING: line over 80 characters > #588: FILE: drivers/media/platform/coda.c:1114: > + value |= (q_data_src->height & CODA7_PICHEIGHT_MASK) << > CODA_PICHEIGHT_OFFSET; > > total: 0 errors, 6 warnings, 603 lines checked > > Best wishes, -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
