Hi Sachin,
Thanks for comment.
On 05/28/2013 10:42 AM, Sachin Kamat wrote:
> Hi Andrzej,
>
> On 28 May 2013 12:56, Andrzej Hajda <a.hajda@xxxxxxxxxxx> wrote:
>> Many debug messages missed end-of-line.
>>
>> Signed-off-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx>
>> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
>> ---
>> drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 +-
>> drivers/media/platform/s5p-mfc/s5p_mfc_debug.h | 4 ++--
>> drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 16 ++++++++--------
>> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c | 4 ++--
>> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 16 ++++++++--------
>> drivers/media/platform/s5p-mfc/s5p_mfc_pm.c | 4 ++--
>> 6 files changed, 23 insertions(+), 23 deletions(-)
> Instead of changing in so many places, can't we add it in the macro
> itself, something like this?
> #define mfc_debug(level, fmt, args...) \
> do { \
> if (debug >= level) \
> - printk(KERN_DEBUG "%s:%d: " fmt, \
> + printk(KERN_DEBUG "%s:%d: " fmt "\n", \
> __func__, __LINE__, ##args); \
> } while (0)
Enforcing EOL in mfc_debug will result in removing EOL from above 120 places
where it is currently used :) Also similar change probably should be
made with
mfc_err to make it consistent.
Anyway such change seems to be not consistent with other printk related
functions.
Regards
Andrzej
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
