On 21 May 2013 14:58, Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
> On Fri 17 May 2013 10:24:50 Sachin Kamat wrote:
>> Hi Hans,
>>
>> I noticed the following sparse warnings with S5P HDMI driver which I
>> think got introduced due to the following commit:
>> 5efb54b2b7b ([media] s5p-tv: add dv_timings support for hdmi)
>>
>> Warnings:
>> drivers/media/platform/s5p-tv/hdmi_drv.c:483:18: error: unknown field
>> name in initializer
>> drivers/media/platform/s5p-tv/hdmi_drv.c:484:18: error: unknown field
>> name in initializer
>> drivers/media/platform/s5p-tv/hdmi_drv.c:485:18: error: unknown field
>> name in initializer
>> drivers/media/platform/s5p-tv/hdmi_drv.c:486:18: error: unknown field
>> name in initializer
>> drivers/media/platform/s5p-tv/hdmi_drv.c:487:18: error: unknown field
>> name in initializer
>> drivers/media/platform/s5p-tv/hdmi_drv.c:488:18: error: unknown field
>> name in initializer
>> drivers/media/platform/s5p-tv/hdmi_drv.c:489:18: error: unknown field
>> name in initializer
>> drivers/media/platform/s5p-tv/hdmi_drv.c:490:18: error: unknown field
>> name in initializer
>> drivers/media/platform/s5p-tv/hdmi_drv.c:491:18: error: unknown field
>> name in initializer
>> drivers/media/platform/s5p-tv/hdmi_drv.c:492:18: error: unknown field
>> name in initializer
>>
>> This looks like the anonymous union initialization problem with GCC.
>> Surprisingly I get this with GCC 4.6, 4.7 and 4.8 as well.
>>
>> If I add additional braces to the macro V4L2_INIT_BT_TIMINGS like done
>> for GCC version < 4.6
>> like
>> { .bt = { _width , ## args } }
>>
>> or if I change the GNUC_MINOR comparison to 9 like (__GNUC_MINOR__ < 9)
>> I dont see this error.
>>
>> I am using the Linaro GCC toolchain.
>>
>> I am not sure if this has already been reported and/or fixed.
>>
>
> Could it be that a different compiler version is used when using sparse?
> I don't see these errors when running sparse during the daily build.
Please let me know your compiler version. I could probably try with it and see.
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
