Am 20.05.2013 01:04, schrieb Chris Rankin: > ----- Original Message ----- > >> What happens with kernel 3.8 ? Does ir-keytable trigger an >> em28xx_ir_change_protocol() call there, too, but with type=8 ? Or is this call missing ? > This is the dmesg output from 3.8, with an extra ex28xx_info() call at the start of em28xx_ir_change_protocol(): > > [ 2149.668729] Em28xx: Initialized (Em28xx dvb Extension) extension > [ 2149.674447] em28xx #0: Changing protocol: rc_type=1 > [ 2149.700087] Registered IR keymap rc-pinnacle-pctv-hd > [ 2149.700444] input: em28xx IR (em28xx #0) as /devices/pci0000:00/0000:00:1d.7/usb5/5-1/rc/rc0/input15 > [ 2149.700655] rc0: em28xx IR (em28xx #0) as /devices/pci0000:00/0000:00:1d.7/usb5/5-1/rc/rc0 > [ 2149.700660] em28xx #0: Changing protocol: rc_type=8 > [ 2149.702337] Em28xx: Initialized (Em28xx Input Extension) extension > [ 2149.704204] em28xx #0: Changing protocol: rc_type=1 > > And this is me calling ir-keytable: > > [ 2183.812407] em28xx #0: Changing protocol: rc_type=1 So with 3.8 the same happens as with 3.9. Well, if ir-keycode / the RC core requests RC_BIT_UNKNOWN, they get RC_BIT_UNKNOWN. ;) If you expect the device to be configured for another protocol (RC5 ?), you need to find out what's going wrong in the RC core and/or ir-keycode. > The point is that 3.8 ignores rc_type=1, whereas 3.9 uses it to update a new ir->rc_type field - which in turn controls how em2874_polling_getkey() encodes its scancode. Indeed, since 3.9 1.) em2874_polling_getkey() cares about the rc_type 2.) the new rc_type is saved back to ir->rc_type AFAICS both changes are correct. But there was a third change: 3.) the scancode passed to the RC core with rc_keypress() in case of RC_BIT_UNKNOWN changed from a 16 bit value to 32 bit value (e.g.: old: 00 00 ab cd => new: ab cd xx xx). Hmm... isn't this an ABI break !? Regards, Frank -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
