On Sat, 18 May 2013, Sergei Shtylyov wrote:
> Hello.
>
> On 05/15/2013 09:44 AM, Guennadi Liakhovetski wrote:
>
> >
> > > From: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx>
> > >
> > > Add Renesas R-Car VIN (Video In) V4L2 driver.
> > >
> > > Based on the patch by Phil Edworthy <phil.edworthy@xxxxxxxxxxx>.
> > >
> > > Signed-off-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx>
> > > [Sergei: removed deprecated IRQF_DISABLED flag, reordered/renamed 'enum
> > > chip_id'
> > > values, reordered rcar_vin_id_table[] entries, removed senseless parens
> > > from
> > > to_buf_list() macro, used ALIGN() macro in rcar_vin_setup(), added {} to
> > > the
> > > *if* statement and used 'bool' values instead of 0/1 where necessary,
> > > done
> > > some reformatting and clarified some comments.]
> > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
> > >
> > > ---
> > > This patch is against the 'media_tree.git' repo.
> > >
> > > Changes since version 3:
> > Why aren't you using this:
> >
> > http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/63820
> >
> > ?
> >
> > Thanks
> > Guennadi
>
> We have now incorporated the needed changes and I will post the updated
> patch.
> I must note that you haven't managed to get rid of all CEU references in the
> shared
> soc_scale_crop.c module, both in the variable names and in the comments.
Ok, I'll try to remember this and prepare an improved v2. Otherwise you're
welcome to suggest an improvement. As long as those "ceu" occurrences
aren't exposed in the API, it shouldn't affect users though.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
