Hi Laurent, Thanks for the review. On Thu, May 16, 2013 at 6:32 PM, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > Hi Prabhakar, > > Thank you for the patch. > > On Thursday 16 May 2013 18:28:16 Lad Prabhakar wrote: >> From: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx> >> >> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx> >> --- >> drivers/media/platform/davinci/vpif.c | 7 ------- >> 1 files changed, 0 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/media/platform/davinci/vpif.c >> b/drivers/media/platform/davinci/vpif.c index ea82a8b..d354d50 100644 >> --- a/drivers/media/platform/davinci/vpif.c >> +++ b/drivers/media/platform/davinci/vpif.c >> @@ -17,18 +17,11 @@ >> * GNU General Public License for more details. >> */ >> >> -#include <linux/init.h> >> #include <linux/module.h> >> #include <linux/platform_device.h> >> -#include <linux/spinlock.h> >> -#include <linux/kernel.h> >> -#include <linux/io.h> >> -#include <linux/err.h> >> #include <linux/pm_runtime.h> >> #include <linux/v4l2-dv-timings.h> > > I think you should keep most of those includes. For instance this file uses > spinlock functions, so linux/spinlock.h should be included. It might work fine > now due to nested includes, but if someone reorganizes the kernel headers > internal includes then the driver might break. As a general rule of good > practice you should include headers for all the APIs you use. > OK, do you want me too drop the similar patches from this series ? Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
