Hi Sylwester, Thanks for the review. On Thu, May 16, 2013 at 4:15 PM, Sylwester Nawrocki <sylvester.nawrocki@xxxxxxxxx> wrote: > On 05/15/2013 02:52 PM, Lad Prabhakar wrote: >> >> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt >> b/Documentation/devicetree/bindings/media/video-interfaces.txt >> index e022d2d..6bf87d0 100644 >> --- a/Documentation/devicetree/bindings/media/video-interfaces.txt >> +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt >> @@ -101,6 +101,10 @@ Optional endpoint properties >> array contains only one entry. >> - clock-noncontinuous: a boolean property to allow MIPI CSI-2 >> non-continuous >> clock mode. >> +-field-active: a boolean property indicating active high filed ID output >> + polarity is inverted. > > > You can drop this property and use the existing 'field-even-active' property > instead. > OK > >> +-sync-on-green: a boolean property indicating to sync with the green >> signal in >> + RGB. > > >> diff --git a/include/media/v4l2-mediabus.h b/include/media/v4l2-mediabus.h >> index 83ae07e..b95553d 100644 >> --- a/include/media/v4l2-mediabus.h >> +++ b/include/media/v4l2-mediabus.h >> @@ -40,6 +40,8 @@ >> #define V4L2_MBUS_FIELD_EVEN_HIGH (1<< 10) >> /* FIELD = 1/0 - Field1 (odd)/Field2 (even) */ >> #define V4L2_MBUS_FIELD_EVEN_LOW (1<< 11) >> +#define V4L2_MBUS_FIELD_ACTIVE (1<< 12) >> +#define V4L2_MBUS_SOG (1<< 13) > > > How about V4L2_MBUS_SYNC_ON_GREEN ? > OK makes it more readable. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
