Re: [PATCH] [media] s5c73m3: Fix off-by-one valid range checking for fie->index

[Andrzej Hajda <a.hajda@xxxxxxxxxxx>]

Hi Axel,

Thanks for the fix.


On 30.04.2013 06:42, Axel Lin wrote:
> Current code uses fie->index as array subscript, thus the valid value range
> is 0 ... ARRAY_SIZE(s5c73m3_intervals) - 1.
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
Acked-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx>
> ---
>   drivers/media/i2c/s5c73m3/s5c73m3-core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
> index b353c50..cd365bb 100644
> --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c
> +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
> @@ -956,7 +956,7 @@ static int s5c73m3_oif_enum_frame_interval(struct v4l2_subdev *sd,
>   
>   	if (fie->pad != OIF_SOURCE_PAD)
>   		return -EINVAL;
> -	if (fie->index > ARRAY_SIZE(s5c73m3_intervals))
> +	if (fie->index >= ARRAY_SIZE(s5c73m3_intervals))
>   		return -EINVAL;
>   
>   	mutex_lock(&state->lock);

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html