On Monday 29 April 2013 17:18:02 Prabhakar Lad wrote: > On Mon, Apr 29, 2013 at 5:05 PM, Laurent Pinchart wrote: > > Hi Prabhakar, > > > > Thank you for the patch. Please see below for a couple of comments in > > addition to the ones I've just sent (in reply to Sascha's e-mail). > > Yep fixed them all. > > [snip] > > >> --- > >> > >> .../devicetree/bindings/media/i2c/mt9p031.txt | 43 ++++++++++++++ > >> drivers/media/i2c/mt9p031.c | 61 +++++++++++++- > >> 2 files changed, 103 insertions(+), 1 deletions(-) > >> create mode 100644 > >> Documentation/devicetree/bindings/media/i2c/mt9p031.txt > >> > >> diff --git a/Documentation/devicetree/bindings/media/i2c/mt9p031.txt > >> b/Documentation/devicetree/bindings/media/i2c/mt9p031.txt new file mode > >> 100644 > >> index 0000000..b985e63 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/media/i2c/mt9p031.txt > >> @@ -0,0 +1,43 @@ > >> +* Aptina 1/2.5-Inch 5Mp CMOS Digital Image Sensor > >> + > >> +The Aptina MT9P031 is a 1/2.5-inch CMOS active pixel digital image > >> +sensor with an active imaging pixel array of 2592H x 1944V. It > >> +incorporates sophisticated camera functions on-chip such as windowing, > >> +column and row skip mode, and snapshot mode. It is programmable through > >> +a simple two-wire serial interface. > >> +The MT9P031 is a progressive-scan sensor that generates a stream of > >> +pixel data at a constant frame rate. It uses an on-chip, phase-locked > >> +loop (PLL) to generate all internal clocks from a single master input > >> +clock running between 6 and 27 MHz. The maximum pixel rate is 96 Mp/s, > >> +corresponding to a clock rate of 96 MHz. > > > > Isn't this text (directly copied from the datasheet) under Aptina's > > copyright ? > > hmm :) do you want me change it ? >From a personal point of view I don't care much, and I don't think Aptina would either, but I'd rather be safe than sorry on such matters, so it would probably be a good idea to change the text. One or two sentences should be enough. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
