Hi Guennadi,
On Thursday 18 April 2013 23:47:26 Guennadi Liakhovetski wrote:
> On Thu, 18 Apr 2013, Guennadi Liakhovetski wrote:
> > Adding struct v4l2_subdev_platform_data to mt9p031's platform data allows
> > the driver to use generic functions to manage sensor power supplies.
> >
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
>
> A small addition to this one too: to be absolutely honest, I also had to
> replace 12-bit formats with their 8-bit counterparts, because only 8 data
> lanes are connected to my camera host. We'll need to somehow properly
> solve this too.
That information should be conveyed by platform/DT data for the host, and be
used to convert the 12-bit media bus code into a 8-bit media bus code in the
host (a core helper function would probably be helpful).
> > ---
> >
> > drivers/media/i2c/mt9p031.c | 1 +
> > include/media/mt9p031.h | 3 +++
> > 2 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c
> > index 70f4525..ca2cc6e 100644
> > --- a/drivers/media/i2c/mt9p031.c
> > +++ b/drivers/media/i2c/mt9p031.c
> > @@ -1048,6 +1048,7 @@ static int mt9p031_probe(struct i2c_client *client,
> > goto done;
> >
> > mt9p031->subdev.dev = &client->dev;
> > + mt9p031->subdev.pdata = &pdata->sd_pdata;
> > ret = v4l2_async_register_subdev(&mt9p031->subdev);
> >
> > done:
> > diff --git a/include/media/mt9p031.h b/include/media/mt9p031.h
> > index 0c97b19..7bf7b53 100644
> > --- a/include/media/mt9p031.h
> > +++ b/include/media/mt9p031.h
> > @@ -1,6 +1,8 @@
> > #ifndef MT9P031_H
> > #define MT9P031_H
> >
> > +#include <media/v4l2-subdev.h>
> > +
> > struct v4l2_subdev;
> > /*
> > @@ -15,6 +17,7 @@ struct mt9p031_platform_data {
> > int reset;
> > int ext_freq;
> > int target_freq;
> > + struct v4l2_subdev_platform_data sd_pdata;
> > };
> >
> > #endif
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
