Hi,
On 04/20/2013 10:16 PM, Sergei Shtylyov wrote:
From: Vladimir Barinov<vladimir.barinov@xxxxxxxxxxxxxxxxxx>
Add OKI Semiconductor ML86V7667 video decoder driver.
Signed-off-by: Vladimir Barinov<vladimir.barinov@xxxxxxxxxxxxxxxxxx>
[Sergei: added v4l2_device_unregister_subdev() call to the error cleanup path of
ml86v7667_probe(); some cleanup.]
Signed-off-by: Sergei Shtylyov<sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
---
drivers/media/i2c/Kconfig | 9
drivers/media/i2c/Makefile | 1
drivers/media/i2c/ml86v7667.c | 504 ++++++++++++++++++++++++++++++++++++++++++
3 files changed, 514 insertions(+)
+static int ml86v7667_cropcap(struct v4l2_subdev *sd, struct v4l2_cropcap *a)
+{
+ struct ml86v7667_priv *priv = to_ml86v7667(sd);
+
+ ml86v7667_querystd(sd,&priv->std);
+
+ a->bounds.left = 0;
+ a->bounds.top = 0;
+ a->bounds.width = 720;
+ a->bounds.height = priv->std& V4L2_STD_525_60 ? 480 : 576;
+ a->defrect = a->bounds;
+ a->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
+ a->pixelaspect.numerator = 1;
+ a->pixelaspect.denominator = 1;
+
+ return 0;
+}
+static struct v4l2_subdev_video_ops ml86v7667_subdev_video_ops = {
+ .querystd = ml86v7667_querystd,
+ .g_input_status = ml86v7667_g_input_status,
+ .enum_mbus_fmt = ml86v7667_enum_mbus_fmt,
+ .try_mbus_fmt = ml86v7667_try_mbus_fmt,
+ .g_mbus_fmt = ml86v7667_g_mbus_fmt,
+ .s_mbus_fmt = ml86v7667_s_mbus_fmt,
+ .cropcap = ml86v7667_cropcap,
+ .g_mbus_config = ml86v7667_g_mbus_config,
+};
Why do you need .cropcap when there is no s_crop/g_crop ops ? Is it
only for pixel aspect ratio ?
Also, new drivers are supposed to use the selections API instead
(set/get_selection ops). However this requires pad level ops support
in your host driver, hence might be a bigger issue.
Regards,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
