On Thu April 18 2013 23:35:21 Guennadi Liakhovetski wrote: > This is the first very crude shot at the subdevice pad-level API wrapper. > The actual wrapper is added in patch #21, previous 20 patches are > preparation... They apply on top of the last version of my async / clock > patch series, respectively, on top of the announced branch of my linuxtv > git-tree. Patches 2 and 4 from this series should actually be merged into > respective patches from the async series. > > I'm publishing this patch-series now, because I don't know when and how > much time I'll have to improve it... Maybe you don't want to spend too much > time reviewing implementation details, but comments to general concepts > would be appreciated. > > Further note, that patches 8-12 aren't really required. We can keep the > deprecated struct soc_camera_link for now, or use a more gentle and slow > way to remove it. I just wanted to say that there is much here that I like very a lot. I would suggest splitting the patch series in two: first the struct v4l2_subdev_platform_data & soc_camera_link removal, then the patches dealing with the pad-level API. The first part looks very nice, really the only problem I have there is with the host_priv field, which should be easy enough to fix. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html