Hi Sylwester,
On 15 April 2013 20:51, Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> wrote:
>> - if (!fimc->drv_data || fimc->id >= fimc->drv_data->num_entities ||
>> - fimc->id < 0) {
>> - dev_err(dev, "Invalid driver data or device id (%d/%d)\n",
>> - fimc->id, fimc->drv_data->num_entities);
>> + if (!fimc->drv_data || fimc->id >= fimc->drv_data->num_entities) {
>> + dev_err(dev, "Invalid driver data or device id (%d)\n",
>> + fimc->id);
>> return -EINVAL;
>
> Thanks for the patch. To make it more explicit I would prefer to change
> id type to 'int', and to leave the check for negative value. There is
> a similar issue in fimc-lite.c that could be addressed in same patch.
> Could you also fix this and resend ?
Sure.
I also found a few more things to fix and sent a 5 patch fix series
including the above changes.
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
