On Fri, Apr 05, 2013 at 01:18:54PM -0300, Mauro Carvalho Chehab wrote: > Could you please test the enclosed patch? It allows the bridge > driver to tell if the set_tone should be overrided by isl6421 or > not. Yes, your patch works fine for me, backported to 3.4, which was just a case of changing the paths: http://offog.org/stuff/bug9476v2.diff Tested-by: Adam Sampson <ats@xxxxxxxxx> I've tested it on my "Hauppauge model 92001, rev C1B1, serial# 1888307" board with lowband V, lowband H, highband V and highband H transponders, so both tone and voltage switching are working. I've not tested it on any other boards. > --- a/drivers/media/dvb-frontends/isl6421.h > +++ b/drivers/media/dvb-frontends/isl6421.h > @@ -42,10 +42,10 @@ > #if IS_ENABLED(CONFIG_DVB_ISL6421) > /* override_set and override_clear control which system register bits (above) to always set & clear */ > extern struct dvb_frontend *isl6421_attach(struct dvb_frontend *fe, struct i2c_adapter *i2c, u8 i2c_addr, > - u8 override_set, u8 override_clear); > + u8 override_set, u8 override_clear, bool override_tone); It might be worth adding a comment there saying what override_tone is actually doing? Thanks very much, -- Adam Sampson <ats@xxxxxxxxx> <http://offog.org/> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
