On Tue, 2 Apr 2013, Arnd Bergmann wrote: > On Tuesday 02 April 2013, Guennadi Liakhovetski wrote: > > Currently modular V4L2 build with enabled OF is broken dur to the > > of_get_next_parent() function being unavailable to modules. Export it to > > fix the build. > > > > Cc: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> > > Looks good to me, but shouldn't this be EXPORT_SYMBOL_GPL? "grep EXPORT_SYMBOL drivers/of/base.c" doesn't give a certain answer, but it seems to fit other of_get_* functions pretty well: EXPORT_SYMBOL(of_get_parent); +EXPORT_SYMBOL(of_get_next_parent); EXPORT_SYMBOL(of_get_next_child); EXPORT_SYMBOL(of_get_next_available_child); EXPORT_SYMBOL(of_get_child_by_name); Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
