Re: [PATCH] V4L: Remove incorrect EXPORT_SYMBOL() usage at v4l2-of.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2 Apr 2013, Sylwester Nawrocki wrote:

> Hi Guennadi,
> 
> On 04/02/2013 04:54 PM, Guennadi Liakhovetski wrote:
> > On Tue, 2 Apr 2013, Sylwester Nawrocki wrote:
> > 
> >> > v4l2_of_parse_parallel_bus() function is now static and
> >> > EXPORT_SYMBOL() doesn't apply to it any more. Drop this
> >> > meaningless statement, which was supposed to be done in
> >> > the original merged patch.
> >> > 
> >> > While at it, edit the copyright notice so it is sorted in
> >> > both the v4l2-of.c and v4l2-of.h file in newest entries
> >> > on top order, and state clearly I'm just the author of
> >> > parts of the code, not the copyright owner.
> >> > 
> >> > Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
> >> > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> >
> > This is not concerning the contents of this patch, but rather the form 
> > confuses me a bit - the two above Sob's: you are the author, and you're 
> > sending the patch to the list, but Kyungmin Park's Sob is the last in the 
> > list, which to me means that your patch went via his tree, but it's you 
> > who's sending it?... I think I saw this pattern in some other your patches 
> > too. What exactly does this mean?
> 
> This means just that Kyungmin approves the patch submission as our manager
> and the internal tree maintainer. He is not necessarily directly involved
> in the development of a patch. As you probably noticed his Signed-off is
> on patches from all our team members. I agree it is not immediately obvious
> what's going on here. This has been discussed in the past few times. For
> instance please refer to this thread:
> 
> http://www.spinics.net/lists/linux-usb/msg74981.html

Ok, thanks, I wasn't aware of this use of Sob.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux