As pointed by Dan Carpenter, there are two smatch warnings on this driver: drivers/media/dvb-frontends/mb86a20s.c:1897 mb86a20s_set_frontend() error: buffer overflow 'mb86a20s_subchannel' 8 <= 8 drivers/media/dvb-frontends/mb86a20s.c:644 mb86a20s_layer_bitrate() error: buffer overflow 'state->estimated_rate' 3 <= 3 While both of them are trivial, one of the errors were due to a bad cut-and-paste silly error, plus the abuse of "i" on loops and array indexes. So, let's fix both errors and remove the "i" temp var abuse on the driver. Mauro Carvalho Chehab (5): [media] mb86a20s: Use a macro for the number of layers [media] mb86a20s: Fix estimate_rate setting [media] mb86a20s: fix audio sub-channel check [media] mb86a20s: Use 'layer' instead of 'i' on all places [media] mb86a20s: better name temp vars at mb86a20s_layer_bitrate() drivers/media/dvb-frontends/mb86a20s.c | 213 +++++++++++++++++---------------- 1 file changed, 108 insertions(+), 105 deletions(-) -- 1.8.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html