On Fri March 29 2013 13:51:42 Mauro Carvalho Chehab wrote: > Em Fri, 29 Mar 2013 12:46:39 +0100 > Hans Verkuil <hverkuil@xxxxxxxxx> escreveu: > > > As discussed earlier (http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/62438) > > let's move this to common. It's a nice cleanup for go7007 as well which had a weird DVB > > dependency. > > > > Regards, > > > > Hans > > > > The following changes since commit 9e7664e0827528701074875eef872f2be1dfaab8: > > > > [media] solo6x10: The size of the thresholds ioctls was too large (2013-03-29 08:34:23 -0300) > > > > are available in the git repository at: > > > > git://linuxtv.org/hverkuil/media_tree.git cypress-common > > > > for you to fetch changes up to 6e69c66b2dafc4927b88a15801e0f84585a28336: > > > > media: move dvb-usb-v2/cypress_firmware.c to media/common. (2013-03-29 12:42:32 +0100) > > > > ---------------------------------------------------------------- > > Hans Verkuil (1): > > media: move dvb-usb-v2/cypress_firmware.c to media/common. > > That broke compilation: > > drivers/media/usb/dvb-usb-v2/az6007.c: In function 'az6007_download_firmware': > drivers/media/usb/dvb-usb-v2/az6007.c:845:2: error: implicit declaration of function 'cypress_load_firmware' [-Werror=implicit-function-declaration] > cc1: some warnings being treated as errors Are you sure you don't have an old cypress_firmware.h lying around? It compiles fine for me. > > > > > drivers/media/common/Kconfig | 3 +++ > > drivers/media/common/Makefile | 2 ++ > > drivers/media/{usb/dvb-usb-v2 => common}/cypress_firmware.c | 77 +++++++++++++++++++++++++++++++++--------------------------------- > > drivers/media/{usb/dvb-usb-v2 => common}/cypress_firmware.h | 9 +++----- > > drivers/media/usb/dvb-usb-v2/Kconfig | 6 +----- > > drivers/media/usb/dvb-usb-v2/Makefile | 5 +---- > > drivers/media/usb/dvb-usb-v2/az6007.c | 2 +- > > drivers/staging/media/go7007/Kconfig | 3 ++- > > drivers/staging/media/go7007/Makefile | 6 +----- > > drivers/staging/media/go7007/go7007-loader.c | 4 ++-- > > 10 files changed, 54 insertions(+), 63 deletions(-) > > > rename drivers/media/{usb/dvb-usb-v2 => common}/cypress_firmware.c (88%) > > rename drivers/media/{usb/dvb-usb-v2 => common}/cypress_firmware.h (68%) > > Why are out there so many changes? There were lots of 'dvb_usbv2_' prefixes that had to be renamed, and I made the get_hexline() function static since it was only used internally. Because of that I had to move the function up in the code. Regards, Hans > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-media" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
