>> This driver support parallel data output mode and
>> QVGA/VGA/WVGA/720P resolution. You can select YCbCr and RGB565
>> output format.
>
> What host bridge do you use this driver with ?
>
I only tested with blackfin.
>
>> + */
>
> [snip]
>
>> +struct mt9m114_reg {
>> + u16 reg;
>> + u32 val;
>> + int width;
>> +};
>> +
>> +enum {
>> + MT9M114_QVGA,
>> + MT9M114_VGA,
>> + MT9M114_WVGA,
>> + MT9M114_720P,
>> +};
>
> This is the part I don't like. Instead of hardcoding 4 different resolutions
> and using large register address/value tables, you should compute the register
> values from the image size requested by the user.
>
In fact we get this table with the Aptina development tool. So we only support
fixed resolutions. If we compute each register value, it only makes
the code more complex.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
