Re: [GIT PULL FOR v3.10] au0828 driver overhaul

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun March 24 2013 18:55:50 Devin Heitmueller wrote:
> On Sun, Mar 24, 2013 at 1:51 PM, Mauro Carvalho Chehab
> <mchehab@xxxxxxxxxx> wrote:
> > drivers/media/dvb-frontends/au8522_decoder.c:static int au8522_g_tuner(struct v4l2_subdev *sd, struct v4l2_tuner *vt)
> > drivers/media/dvb-frontends/au8522_decoder.c-{
> > drivers/media/dvb-frontends/au8522_decoder.c-     int val = 0;
> > drivers/media/dvb-frontends/au8522_decoder.c-     struct au8522_state *state = to_state(sd);
> > drivers/media/dvb-frontends/au8522_decoder.c-     u8 lock_status;
> > drivers/media/dvb-frontends/au8522_decoder.c-
> > drivers/media/dvb-frontends/au8522_decoder.c-     /* Interrogate the decoder to see if we are getting a real signal */
> > drivers/media/dvb-frontends/au8522_decoder.c-     lock_status = au8522_readreg(state, 0x00);
> > drivers/media/dvb-frontends/au8522_decoder.c-     if (lock_status == 0xa2)
> > drivers/media/dvb-frontends/au8522_decoder.c-             vt->signal = 0xffff;
> > drivers/media/dvb-frontends/au8522_decoder.c-     else
> > drivers/media/dvb-frontends/au8522_decoder.c-             vt->signal = 0x00;
> > drivers/media/dvb-frontends/au8522_decoder.c-
> > drivers/media/dvb-frontends/au8522_decoder.c-     vt->capability |=
> > drivers/media/dvb-frontends/au8522_decoder.c-             V4L2_TUNER_CAP_STEREO | V4L2_TUNER_CAP_LANG1 |
> > drivers/media/dvb-frontends/au8522_decoder.c-             V4L2_TUNER_CAP_LANG2 | V4L2_TUNER_CAP_SAP;
> > drivers/media/dvb-frontends/au8522_decoder.c-
> > drivers/media/dvb-frontends/au8522_decoder.c-     val = V4L2_TUNER_SUB_MONO;
> > drivers/media/dvb-frontends/au8522_decoder.c-     vt->rxsubchans = val;
> > drivers/media/dvb-frontends/au8522_decoder.c-     vt->audmode = V4L2_TUNER_MODE_STEREO;
> > drivers/media/dvb-frontends/au8522_decoder.c-     return 0;
> >
> > As if the i2c gate is on a wrong state, au8522_readreg() won't
> > work anymore.
> 
> Note that au8522_g_tuner function never actually talks to the tuner.
> It's handled entirely within the au8522 driver, which is not behind
> the gate.  The I2C gate is only required if talking to the xc5000, not
> the au8522.
> 
> There's something else broken here.  I suspect it's probably some
> artifact of the conversion to the new control framework (if I had to
> guess).

Rather than guessing I'll be doing some testing this week. It could also be
a crappy antenna connection as that's been giving me some grief lately (due
to an unholy BNC-to-F-connector-to-coax adapter chain).

Regards,

	Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux