Re: [REVIEW PATCH 01/19] solo6x10: sync to latest code from Bluecherry's git repo.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun March 24 2013 15:27:23 Mauro Carvalho Chehab wrote:
> Em Mon, 18 Mar 2013 13:32:00 +0100
> Hans Verkuil <hverkuil@xxxxxxxxx> escreveu:
> 
> > From: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> > 
> > Synced to commit e9815ac5503ae60cfbf6ff8037035de8f62e2846 from
> > branch next in git repository https://github.com/bluecherrydvr/solo6x10.git
> > 
> > Only removed some code under #if LINUX_VERSION_CODE < some-kernel-version,
> > renamed the driver back to solo6x10 from solo6x10-edge and removed the
> > unnecessary compat.h header.
> > 
> > Otherwise the code is identical.
> > 
> 
> ...
> 
> > @@ -21,29 +26,78 @@
> >  #include <linux/module.h>
> >  #include <linux/pci.h>
> >  #include <linux/interrupt.h>
> > -#include <linux/slab.h>
> 
> You can't remove slab.h if any k*alloc function is used, or it will
> break compilation, depending on the Kconfig options selected.

Well spotted, thanks!

> 
> The same type of removal are on other files inside this patch.
> 
> Please fix.

Done. New pull request posted.

Regards,

	Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux