Re: NACK: [PATCH] [media] s5p-mfc: Modify encoder buffer alloc sequence

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi John Sheu,

On Thu, Mar 21, 2013 at 7:30 AM, John Sheu <sheu@xxxxxxxxxx> wrote:
> Arun Kumar K <arun.kk <at> samsung.com> writes:
>
>> MFC v6 needs minimum number of capture buffers to be queued
>> for encoder depending on the stream type and profile.
>> For achieving this the sequence for allocating buffers at
>> the encoder is modified similar to that of decoder.
>> The new sequence is as follows:
>>
>> 1) Set format on CAPTURE plane
>> 2) REQBUF on CAPTURE
>> 3) QBUFS and STREAMON on CAPTURE
>> 4) G_CTRL to get minimum buffers for OUTPUT plane
>> 5) REQBUF on OUTPUT with the minimum buffers given by driver
>
> NACK: the commit summary mentions the CAPTURE queue, but we're actually changing
> the OUTPUT queue allocation sequence.  Please fix.
>

Thanks for pointing out this mistake. Will correct it and post.
Is there any more Acks/ Nacks/ Comments on this?

Regards
Arun
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux