Re: [REVIEW PATCH 11/15] au0828: fix disconnect sequence.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 20, 2013 at 3:20 PM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
> I want to make a pull request for this. Can I have your Acked-by or do you
> want to look at this some more?

I *looked* at all the patches, and they all look fine.  That said, I
haven't actually installed them at all and seen if anything got
broken.  The logic is so convoluted that it's entirely possible there
is breakage that wouldn't be obvious simply by reviewing the patches
without actual testing with real application (and no, v4l-2ctl and
v4l2-compliance do *not* count as real applications).

Did you try the resulting patches with anything other than
v4l2-compliance/v4l2-ctl?  tvtime?  xawtv?  mythtv?

Hence, for what it's worth:

Reviewed-by: Devin Heitmueller <dheitmueller@xxxxxxxxxxxxxx>

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux