Hi Eduardo! On Tue 19 March 2013 16:41:30 Eduardo Valentin wrote: > Hello Mauro and Hans, > > Here are a couple of minor changes for si4713 FM transmitter driver. Thanks! Patches 2-4 are fine, but I don't really see the point of the first patch (except for the last chunk which is a real improvement). The Codingstyle doesn't require such alignment, and in fact it says: "Descendants are always substantially shorter than the parent and are placed substantially to the right. The same applies to function headers with a long argument list." Unless Mauro thinks otherwise, I would leave all the alignment stuff alone and just post a version with the last chunk. For patches 2-4: Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> Are you still able to test the si4713 driver? Because I have patches outstanding that I would love for someone to test for me: http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/refs/heads/si4713 In particular, run the latest v4l2-compliance test over it. Regards, Hans > > These changes are also available here: > https://git.gitorious.org/si4713/si4713.git > > All best, > > Eduardo Valentin (4): > media: radio: CodingStyle changes on si4713 > media: radio: correct module license (==> GPL v2) > media: radio: add driver owner entry for radio-si4713 > media: radio: add module alias entry for radio-si4713 > > drivers/media/radio/radio-si4713.c | 57 ++++++++++++++++++----------------- > 1 files changed, 29 insertions(+), 28 deletions(-) > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
