Re: [PATCH] [media] mx2_camera: use module_platform_driver_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Fabio

On Mon, 18 Mar 2013, Fabio Porcedda wrote:

> The commit 39793c6 "[media] mx2_camera: Convert it to platform driver"
> used module_platform_driver() to make code smaller,
> but since the driver used platform_driver_probe is more appropriate
> to use module_platform_driver_probe().
> 
> Signed-off-by: Fabio Porcedda <fabio.porcedda@xxxxxxxxx>
> Cc: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> Cc: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>

Thanks, will queue for 3.10.

Guennadi

> ---
>  drivers/media/platform/soc_camera/mx2_camera.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/soc_camera/mx2_camera.c b/drivers/media/platform/soc_camera/mx2_camera.c
> index ffba7d9..848dff9 100644
> --- a/drivers/media/platform/soc_camera/mx2_camera.c
> +++ b/drivers/media/platform/soc_camera/mx2_camera.c
> @@ -1619,10 +1619,9 @@ static struct platform_driver mx2_camera_driver = {
>  	},
>  	.id_table	= mx2_camera_devtype,
>  	.remove		= mx2_camera_remove,
> -	.probe		= mx2_camera_probe,
>  };
>  
> -module_platform_driver(mx2_camera_driver);
> +module_platform_driver_probe(mx2_camera_driver, mx2_camera_probe);
>  
>  MODULE_DESCRIPTION("i.MX27 SoC Camera Host driver");
>  MODULE_AUTHOR("Sascha Hauer <sha@xxxxxxxxxxxxxx>");
> -- 
> 1.8.2
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux