On Thu, Mar 14, 2013 at 2:25 PM, Guennadi Liakhovetski <g.liakhovetski@xxxxxx> wrote: > Hi Fabio > > On Thu, 14 Mar 2013, Fabio Porcedda wrote: > >> This patch converts the drivers to use the >> module_platform_driver_probe() macro which makes the code smaller and >> a bit simpler. >> >> Signed-off-by: Fabio Porcedda <fabio.porcedda@xxxxxxxxx> >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> >> Cc: Josh Wu <josh.wu@xxxxxxxxx> >> Cc: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> >> Cc: Hans Verkuil <hans.verkuil@xxxxxxxxx> >> Cc: linux-media@xxxxxxxxxxxxxxx > > Thanks for the patch. Subtracting this series > http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/61403 > you only need to convert atmel-isi.c. Please, respin. Ok, I'll send a updated one. Thanks for the reviewing the patch. Best regards Fabio Porcedda > Thanks > Guennadi > >> --- >> drivers/media/platform/sh_vou.c | 13 +------------ >> drivers/media/platform/soc_camera/atmel-isi.c | 12 +----------- >> drivers/media/platform/soc_camera/mx1_camera.c | 13 +------------ >> 3 files changed, 3 insertions(+), 35 deletions(-) >> >> diff --git a/drivers/media/platform/sh_vou.c b/drivers/media/platform/sh_vou.c >> index 66c8da1..d853162 100644 >> --- a/drivers/media/platform/sh_vou.c >> +++ b/drivers/media/platform/sh_vou.c >> @@ -1485,18 +1485,7 @@ static struct platform_driver __refdata sh_vou = { >> }, >> }; >> >> -static int __init sh_vou_init(void) >> -{ >> - return platform_driver_probe(&sh_vou, sh_vou_probe); >> -} >> - >> -static void __exit sh_vou_exit(void) >> -{ >> - platform_driver_unregister(&sh_vou); >> -} >> - >> -module_init(sh_vou_init); >> -module_exit(sh_vou_exit); >> +module_platform_driver_probe(sh_vou, sh_vou_probe); >> >> MODULE_DESCRIPTION("SuperH VOU driver"); >> MODULE_AUTHOR("Guennadi Liakhovetski <g.liakhovetski@xxxxxx>"); >> diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi.c >> index 82dbf99..12ba31d 100644 >> --- a/drivers/media/platform/soc_camera/atmel-isi.c >> +++ b/drivers/media/platform/soc_camera/atmel-isi.c >> @@ -1081,17 +1081,7 @@ static struct platform_driver atmel_isi_driver = { >> }, >> }; >> >> -static int __init atmel_isi_init_module(void) >> -{ >> - return platform_driver_probe(&atmel_isi_driver, &atmel_isi_probe); >> -} >> - >> -static void __exit atmel_isi_exit(void) >> -{ >> - platform_driver_unregister(&atmel_isi_driver); >> -} >> -module_init(atmel_isi_init_module); >> -module_exit(atmel_isi_exit); >> +module_platform_driver_probe(atmel_isi_driver, atmel_isi_probe); >> >> MODULE_AUTHOR("Josh Wu <josh.wu@xxxxxxxxx>"); >> MODULE_DESCRIPTION("The V4L2 driver for Atmel Linux"); >> diff --git a/drivers/media/platform/soc_camera/mx1_camera.c b/drivers/media/platform/soc_camera/mx1_camera.c >> index 25b2a28..4389f43 100644 >> --- a/drivers/media/platform/soc_camera/mx1_camera.c >> +++ b/drivers/media/platform/soc_camera/mx1_camera.c >> @@ -859,18 +859,7 @@ static struct platform_driver mx1_camera_driver = { >> .remove = __exit_p(mx1_camera_remove), >> }; >> >> -static int __init mx1_camera_init(void) >> -{ >> - return platform_driver_probe(&mx1_camera_driver, mx1_camera_probe); >> -} >> - >> -static void __exit mx1_camera_exit(void) >> -{ >> - return platform_driver_unregister(&mx1_camera_driver); >> -} >> - >> -module_init(mx1_camera_init); >> -module_exit(mx1_camera_exit); >> +module_platform_driver_probe(mx1_camera_driver, mx1_camera_probe); >> >> MODULE_DESCRIPTION("i.MX1/i.MXL SoC Camera Host driver"); >> MODULE_AUTHOR("Paulius Zaleckas <paulius.zaleckas@xxxxxxxxxxxx>"); >> -- >> 1.8.1.5 >> > > --- > Guennadi Liakhovetski, Ph.D. > Freelance Open-Source Software Developer > http://www.open-technology.de/ -- Fabio Porcedda -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
