Hi Sylwester,
On Thu, Mar 7, 2013 at 3:40 AM, Sylwester Nawrocki
<sylvester.nawrocki@xxxxxxxxx> wrote:
> Hi Arun,
>
>
> On 03/06/2013 02:15 PM, Arun Kumar K wrote:
>>
>> mfc-encoder is not working in the latest kernel giving the
>> erorr "Adding control (15) failed". Adding the missing step
>> parameter in this control to fix the issue.
>
>
> Do you mean this problem was not observed in 3.8 kernel and something
> has changed in the v4l2 core so it fails in 3.9-rc now ? Or is it
> related to some change in the driver itself ?
v4l2_ctrl_new() uses check_range() for control range checking (which
is added newly).
This function expects 'step' value for V4L2_CTRL_TYPE_BOOLEAN type control.
If 'step' value doesn't match to '1', it returns -ERANGE error.
Its a change in v4l2 core.
Regards,
Shaik Ameer Basha
>
>
>> Signed-off-by: Arun Kumar K<arun.kk@xxxxxxxxxxx>
>> ---
>> drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
>> b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
>> index 2356fd5..4f6b553 100644
>> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
>> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
>> @@ -232,6 +232,7 @@ static struct mfc_control controls[] = {
>> .minimum = 0,
>> .maximum = 1,
>> .default_value = 0,
>> + .step = 1,
>> .menu_skip_mask = 0,
>> },
>> {
>
>
> Regards,
> Sylwester
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
