On 3/6/2013 3:46 PM, Prabhakar Lad wrote: > Sekhar, > > On Wed, Mar 6, 2013 at 3:37 PM, Sekhar Nori <nsekhar@xxxxxx> wrote: >> On 3/6/2013 2:59 PM, Prabhakar Lad wrote: >> >>>> config VIDEO_DAVINCI_VPIF_DISPLAY >>>> tristate "DM646x/DA850/OMAPL138 EVM Video Display" >>>> - depends on VIDEO_DEV && (MACH_DAVINCI_DM6467_EVM || MACH_DAVINCI_DA850_EVM) >>>> + depends on VIDEO_DEV && (MACH_DAVINCI_DM6467_EVM || MACH_DAVINCI_DA850_EVM) && VIDEO_DAVINCI_VPIF >>>> select VIDEOBUF2_DMA_CONTIG >>>> - select VIDEO_DAVINCI_VPIF >>>> select VIDEO_ADV7343 if MEDIA_SUBDRV_AUTOSELECT >>>> select VIDEO_THS7303 if MEDIA_SUBDRV_AUTOSELECT >>>> help >>>> @@ -15,9 +14,8 @@ config VIDEO_DAVINCI_VPIF_DISPLAY >>>> >>>> config VIDEO_DAVINCI_VPIF_CAPTURE >>>> tristate "DM646x/DA850/OMAPL138 EVM Video Capture" >>>> - depends on VIDEO_DEV && (MACH_DAVINCI_DM6467_EVM || MACH_DAVINCI_DA850_EVM) >>>> + depends on VIDEO_DEV && (MACH_DAVINCI_DM6467_EVM || MACH_DAVINCI_DA850_EVM) && VIDEO_DAVINCI_VPIF >>>> select VIDEOBUF2_DMA_CONTIG >>>> - select VIDEO_DAVINCI_VPIF >>>> help >>>> Enables Davinci VPIF module used for captur devices. >>>> This module is common for following DM6467/DA850/OMAPL138 >>>> @@ -28,7 +26,7 @@ config VIDEO_DAVINCI_VPIF_CAPTURE >>>> >>>> config VIDEO_DAVINCI_VPIF >>>> tristate "DaVinci VPIF Driver" >>>> - depends on VIDEO_DAVINCI_VPIF_DISPLAY || VIDEO_DAVINCI_VPIF_CAPTURE >>>> + depends on ARCH_DAVINCI >>> >>> It would be better if this was depends on MACH_DAVINCI_DM6467_EVM || >>> MACH_DAVINCI_DA850_EVM >>> rather than 'ARCH_DAVINCI' then you can remove 'MACH_DAVINCI_DM6467_EVM' and >>> 'MACH_DAVINCI_DA850_EVM' dependency from VIDEO_DAVINCI_VPIF_DISPLAY and >>> VIDEO_DAVINCI_VPIF_CAPTURE. So it would be just 'depends on VIDEO_DEV >>> && VIDEO_DAVINCI_VPIF' >> >> I could, but vpif.c seems pretty board independent to me. Are you sure >> no other board would like to build vpif.c? BTW, are vpif_display.c and >> vpif_capture.c really that board specific? May be we can all make them >> depend on ARCH_DAVINCI? >> > VPIF is present only in DM646x and DA850/OMAP-L1138. > vpif.c is common file which is used by vpif_capture and vpif_display. So vpif.c per se doesn't do anything useful. Why the dependency on EVMs? There are other boards for these platform which could use VPIF. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
