Hi Hans, On Mon, Mar 4, 2013 at 3:06 PM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > On Mon March 4 2013 10:29:26 Prabhakar Lad wrote: >> Hi Hans, >> >> On Mon, Mar 4, 2013 at 2:35 PM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote: >> > From: Hans Verkuil <hans.verkuil@xxxxxxxxx> >> > >> > drivers/media/platform/davinci/dm644x_ccdc.c: In function ‘validate_ccdc_param’: >> > drivers/media/platform/davinci/dm644x_ccdc.c:233:32: warning: comparison between ‘enum ccdc_gama_width’ and ‘enum ccdc_data_size’ [-Wenum-compare] >> > >> please refer this discussion [1], where Mauro has suggested >> few options for fixing it. > > Ah, good. I'll try and do a proper fix. > > BTW, does 'CCDC_GAMMA_BITS_15_6' mean '15 bits'? I'm not sure about the meaning > of the '_6' suffix. Also, I assume that 'gama' in 'enum ccdc_gama_width' is a > misspelling for 'gamma', right? > Its the gamma width input, Since the data resolution can be greater than 10-bits, the 10-bits for input to A-Law operation is specified by this bit. 'CCDC_GAMMA_BITS_15_6' means bits 6-15 are input for A-Law operation. Yes 'gama' in 'enum ccdc_gama_width' is misspelled. Regards, --Prabhakar > Regards, > > Hans > >> >> Regards, >> --Prabhakar Lad >> >> [1] https://patchwork.kernel.org/patch/1923091/ >> >> > Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> >> > --- >> > drivers/media/platform/davinci/dm644x_ccdc.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/media/platform/davinci/dm644x_ccdc.c b/drivers/media/platform/davinci/dm644x_ccdc.c >> > index 318e805..41f0a80 100644 >> > --- a/drivers/media/platform/davinci/dm644x_ccdc.c >> > +++ b/drivers/media/platform/davinci/dm644x_ccdc.c >> > @@ -230,7 +230,7 @@ static int validate_ccdc_param(struct ccdc_config_params_raw *ccdcparam) >> > if (ccdcparam->alaw.enable) { >> > if ((ccdcparam->alaw.gama_wd > CCDC_GAMMA_BITS_09_0) || >> > (ccdcparam->alaw.gama_wd < CCDC_GAMMA_BITS_15_6) || >> > - (ccdcparam->alaw.gama_wd < ccdcparam->data_sz)) { >> > + (ccdcparam->alaw.gama_wd < (unsigned)ccdcparam->data_sz)) { >> > dev_dbg(ccdc_cfg.dev, "\nInvalid data line select"); >> > return -1; >> > } >> > -- >> > 1.7.10.4 >> > >> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
