Re: [PATCH v2 1/2] [media] s5p-g2d: Add DT based discovery support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/12/2013 06:30 PM, Sachin Kamat wrote:

Hi Sylwester,

On Wednesday, 6 February 2013, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote:
 This patch adds device tree based discovery support to G2D driver

 Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
 ---
 Based on for_v3.9 branch of below tree:
 git://linuxtv.org/snawrocki/samsung.git

 Changes since v1:
 * Addressed review comments from Sylwester <s.nawrocki@xxxxxxxxxxx>.
 * Modified the compatible string as per the discussions at [1].
 [1] https://patchwork1.kernel.org/patch/2045821/


Does this patch look good?

It looks OK to me. I've sent a pull request including it, but it may
happen it ends up only in 3.10.

I tried to test this patch today and I had to correct some clock
definitions in the common clock API driver [1]. And we already have
quite a few fixes to that patch series.

Shouldn't you also provide a patch adding related OF_DEV_AUXDATA entry ?
How did you test this one ?

When the new clocks driver gets merged (I guess it happens only in 3.10)
I'd like to have the media devices' clock names cleaned up, instead of
names like: {"sclk_fimg2d", "fimg2d"}, {"sclk_fimc", "fimc"},
{"sclk_fimd"/"fimd"}, in clock-names property we could have common names,
e.g. { "sclk", "gate" }. This could simplify a bit subsystems like devfreq.

Also I noticed there are some issues caused by splitting mux + div + gate
clocks into 3 different clocks. One solution to this might be to use the
new composite clock type.

[1] http://www.spinics.net/lists/arm-kernel/msg214149.html
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux