Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
>Andy,
>
>Please review this patch. This fix probably should be fast-tracked to
>3.8 and
>queued for stable 3.7.
>
>ivtv-alsa kept crashing my machine every time I loaded it, and this is
>the
>cause.
>
>Regards,
>
> Hans
>
>This function is called after initialization, so it should never be
>marked
>__init!
>
>Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>---
> drivers/media/pci/ivtv/ivtv-alsa-main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/media/pci/ivtv/ivtv-alsa-main.c
>b/drivers/media/pci/ivtv/ivtv-alsa-main.c
>index 4a221c6..e970cfa 100644
>--- a/drivers/media/pci/ivtv/ivtv-alsa-main.c
>+++ b/drivers/media/pci/ivtv/ivtv-alsa-main.c
>@@ -205,7 +205,7 @@ err_exit:
> return ret;
> }
>
>-static int __init ivtv_alsa_load(struct ivtv *itv)
>+static int ivtv_alsa_load(struct ivtv *itv)
> {
> struct v4l2_device *v4l2_dev = &itv->v4l2_dev;
> struct ivtv_stream *s;
>--
>1.7.10.4
Hans,
I concur. Now I have to check cx18 for the same problem.
Your patch looks good.
Reviewed-by: Andy Walls <awalls@xxxxxxxxxxxxxxxx>
Signed-off-by: Andy Walls <awalls@xxxxxxxxxxxxxxxx>
Regards,
Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
