Hi Laurent, On Wed, Feb 06, 2013 at 10:41:16AM +0100, Laurent Pinchart wrote: > On Wednesday 06 February 2013 07:16:04 Mauro Carvalho Chehab wrote: > > Em Wed, 6 Feb 2013 08:46:35 +0100 Hans Verkuil escreveu: > > > At least aptina-pll.c, smiapp-pll.c and tveeprom.c all have some > > > relationship with i2c. > > > > True, but none of the three are actually i2c drivers; they're just shared > > functions used by drivers helper code. > > > > Hmm... > > > > $ git grep aptina-pll.h drivers/media/ > > drivers/media/i2c/aptina-pll.c:#include "aptina-pll.h" > > drivers/media/i2c/mt9m032.c:#include "aptina-pll.h" > > drivers/media/i2c/mt9p031.c:#include "aptina-pll.h" > > > > $ git grep smiapp-pll.h drivers/media/ > > drivers/media/i2c/smiapp-pll.c:#include "smiapp-pll.h" > > drivers/media/i2c/smiapp-pll.h: * drivers/media/i2c/smiapp-pll.h > > drivers/media/i2c/smiapp/smiapp.h:#include "smiapp-pll.h" > > > > $ git grep smiapp.h drivers/media/ > > drivers/media/i2c/smiapp/smiapp-core.c:#include "smiapp.h" > > drivers/media/i2c/smiapp/smiapp-limits.c:#include "smiapp.h" > > drivers/media/i2c/smiapp/smiapp-quirk.c:#include "smiapp.h" > > drivers/media/i2c/smiapp/smiapp-regs.c:#include "smiapp.h" > > drivers/media/i2c/smiapp/smiapp.h: * drivers/media/i2c/smiapp/smiapp.h > > drivers/media/i2c/smiapp/smiapp.h:#include <media/smiapp.h> > > > > It could make sense to keep those two on I2c, > > I'd like that :-) Those helper functions will likely never be used by non-I2C > drivers. If they are we can reconsider moving them to common/, but for now it > makes sense to keep them in i2c/ in my opinion. Ack to that. I2c is the bus for the time being but the CSI-3 is bi-directional: <URL:http://www.design-reuse.com/sip/30046/mipi-csi-3-camera-serial-interface-receiver/> The sensors using that bus may well have entirely different PLLs though. -- Kind regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
