Re: [RFC PATCH 13/18] tlg2300: fix missing audioset.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon February 4 2013 05:48:36 Huang Shijie wrote:
> 于 2013年01月31日 05:25, Hans Verkuil 写道:
> > From: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> >
> > Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> > ---
> >  drivers/media/usb/tlg2300/pd-video.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/usb/tlg2300/pd-video.c b/drivers/media/usb/tlg2300/pd-video.c
> > index da7cbd4..122f299 100644
> > --- a/drivers/media/usb/tlg2300/pd-video.c
> > +++ b/drivers/media/usb/tlg2300/pd-video.c
> > @@ -903,7 +903,7 @@ static int vidioc_enum_input(struct file *file, void *fh, struct v4l2_input *in)
> >  	 * the audio input index mixed with this video input,
> >  	 * Poseidon only have one audio/video, set to "0"
> >  	 */
> > -	in->audioset	= 0;
> > +	in->audioset	= 1;
> i think it should be 0. it's need to be test.

The audioset field is a bitmask, not an index. So to tell that audio input 0
is available audioset should be set to 1 << 0 == 1.

Regards,

	Hans

> 
> thanks
> Huang Shijie
> >  	in->tuner	= 0;
> >  	in->std		= V4L2_STD_ALL;
> >  	in->status	= 0;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux