Re: [PATCH] media: config option for building tuners

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 24, 2013 at 5:11 PM, Simon Que <sque@xxxxxxxxxxxx> wrote:
> This patch provides a Kconfig option, MEDIA_TUNER_SUPPORT, that
> determines whether media/tuners is included in the build.  This way,
> the tuners don't have to be unconditionally included in the build.
>
> Signed-off-by: Simon Que <sque@xxxxxxxxxxxx>
> ---
>  drivers/media/Kconfig  | 9 +++++++++
>  drivers/media/Makefile | 3 ++-
>  2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> index 4ef0d80..a266da2 100644
> --- a/drivers/media/Kconfig
> +++ b/drivers/media/Kconfig
> @@ -73,6 +73,15 @@ config MEDIA_RC_SUPPORT
>
>           Say Y when you have a TV or an IR device.
>
> +config MEDIA_TUNER_SUPPORT
> +       tristate
> +       help
> +         This enables the tuner modules in the tuners directory.  Use this
> +         option to turn on tuners.  The individual tuner modules can then be
> +         turned on/off one-by-one.
> +
> +         Say Y when you have a V4L/DVB tuner in your system.
> +
>  #
>  # Media controller
>  #      Selectable only for webcam/grabbers, as other drivers don't use it
> diff --git a/drivers/media/Makefile b/drivers/media/Makefile
> index 620f275..679db94 100644
> --- a/drivers/media/Makefile
> +++ b/drivers/media/Makefile
> @@ -8,7 +8,8 @@ media-objs      := media-device.o media-devnode.o media-entity.o
>  # I2C drivers should come before other drivers, otherwise they'll fail
>  # when compiled as builtin drivers
>  #
> -obj-y += i2c/ tuners/
> +obj-y += i2c/
> +obj-$(CONFIG_MEDIA_TUNER_SUPPORT)  += tuners/
>  obj-$(CONFIG_DVB_CORE)  += dvb-frontends/
>
>  #


I don't quite see the benefit of this patch.  Could you explain to us
what the desired effect is that you're looking to achieve?  I believe
that if you have no drivers selected that need tuners, that no tuner
drivers will be built, or at least that's how it used to work.

Even if you did select a driver that uses a tuner, you can enable the
customization options and deselect all of the tuners drivers.  I don't
think this patch is needed at all, if I understand your goal
correctly.

If I'm missing something, please elaborate.

-Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux