On Mon January 28 2013 11:30:46 Mauro Carvalho Chehab wrote: > Em Sun, 27 Jan 2013 20:45:11 +0100 > Ondrej Zary <linux@xxxxxxxxxxxxxxxxxxxx> escreveu: > > > Make saa7134 driver more V4L2 compliant: don't set bogus V4L2_IN_ST_NO_SYNC > > flag in enum_input as it's for digital video only > > > > Signed-off-by: Ondrej Zary <linux@xxxxxxxxxxxxxxxxxxxx> > > --- > > drivers/media/pci/saa7134/saa7134-video.c | 2 -- > > 1 files changed, 0 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/media/pci/saa7134/saa7134-video.c b/drivers/media/pci/saa7134/saa7134-video.c > > index 0b42f0c..fff6735 100644 > > --- a/drivers/media/pci/saa7134/saa7134-video.c > > +++ b/drivers/media/pci/saa7134/saa7134-video.c > > @@ -1757,8 +1757,6 @@ static int saa7134_enum_input(struct file *file, void *priv, > > > > if (0 != (v1 & 0x40)) > > i->status |= V4L2_IN_ST_NO_H_LOCK; > > - if (0 != (v2 & 0x40)) > > - i->status |= V4L2_IN_ST_NO_SYNC; > > if (0 != (v2 & 0x0e)) > > i->status |= V4L2_IN_ST_MACROVISION; > > } > > > Hmm... I'm not sure about this one. Very few drivers use those definitions, > but I suspect that this might potentially break some userspace applications. > > It sounds more likely that v4l-compliance is doing the wrong thing here, > if it is complaining about that. I agree. See my reply to this patch. I'd appreciate your input on that. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
