Hi Sakari, > From: Sakari Ailus [mailto:sakari.ailus@xxxxxx] > Sent: Thursday, January 24, 2013 8:12 PM > [snip] > > > > > > Do you have a list of those other drivers using vb2 that will > report > > > an unknown timestamp type ? > > > > Here are the drivers: > > > > drivers/media/platform/coda.c > > drivers/media/platform/exynos-gsc/gsc-m2m.c > > drivers/media/platform/m2m-deinterlace.c > > drivers/media/platform/marvell-ccic/mcam-core.c > > drivers/media/platform/mem2mem_testdev.c > > drivers/media/platform/mx2_emmaprp.c > > drivers/media/platform/s5p-fimc/fimc-m2m.c > > drivers/media/platform/s5p-g2d/g2d.c > > drivers/media/platform/s5p-jpeg/jpeg-core.c > > drivers/media/platform/s5p-tv/mixer_video.c > > > > These drivers do not fill the timestamp field at all. > > I wonder what should we do to those. Based on a quick look, only mcam- > core.c and s5p-tv/mixer_video.c seem not to be mem-to-mem devices. So > the rest should be COPY, I presume. At least the one I checked seem to > have 1:1 ratio between output and capture buffers. > > I know you didn't break them; they were already broken... But I don't > think it'd be that big task to fix them either. Now that your patchset > introduces the COPY timestamp it'd be nice to see it being properly > used, rather than letting applications see lots of UNKNOWN timestamps > again. Do you think you could have time for that? I agree that they should fixed by adding proper timestamp handling (copy). Currently I have other tasks to do, I might find some time next week to write the patch. I think that the fix for these drivers can be separate to this patch set. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
