Am 23.01.2013 08:35, schrieb Hans Verkuil: > On Tue January 22 2013 20:46:21 Frank Schäfer wrote: >> tuner_g_tuner() is supposed to fill struct v4l2_tuner passed by ioctl >> VIDIOC_G_TUNER, but misses setting the name field. >> >> Signed-off-by: Frank Schäfer <fschaefer.oss@xxxxxxxxxxxxxx> >> Cc: stable@xxxxxxxxxx >> --- >> drivers/media/v4l2-core/tuner-core.c | 1 + >> 1 Datei geändert, 1 Zeile hinzugefügt(+) >> >> diff --git a/drivers/media/v4l2-core/tuner-core.c b/drivers/media/v4l2-core/tuner-core.c >> index b5a819a..95a47cf 100644 >> --- a/drivers/media/v4l2-core/tuner-core.c >> +++ b/drivers/media/v4l2-core/tuner-core.c >> @@ -1187,6 +1187,7 @@ static int tuner_g_tuner(struct v4l2_subdev *sd, struct v4l2_tuner *vt) >> >> if (check_mode(t, vt->type) == -EINVAL) >> return 0; >> + strcpy(vt->name, t->name); >> if (vt->type == t->mode && analog_ops->get_afc) >> vt->afc = analog_ops->get_afc(&t->fe); >> if (analog_ops->has_signal) >> > Nacked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > And the reason is that the tuner field should be filled in by the bridge > driver. That's because you may have multiple tuners and it's only the > bridge driver that will know which tuner is which and what name to give > it. Hmmm... I don't understand. Isn't his a per-tuner (subdev) operation ? If a device has multiple tuners (subdevs) it is called for each of them. So how can the returned tuner name be wrong and why should the bridge driver know better than the subdevice itself which name is correct ? Regards, Frank > Regards, > > Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
